Re: [evolution-patches] (groupwise) using GString
- From: Sivaiah Nallagatla <snallagatla novell com>
- To: sparthasarathi novell com
- Cc: evolution-patches lists ximian com
- Subject: Re: [evolution-patches] (groupwise) using GString
- Date: Thu, 17 Mar 2005 16:46:58 +0530
On Wed, 2005-03-16 at 15:40 +0530, Parthasarathi Susarla wrote:
> + *str = g_strdup (gstr->str);
> *len = strlen (*str) ;
You need not calculate the stting length here, it is already part of
Gstring struct. You are not checking for null checks for may values you
retrieve from EGwItem. Are you sure they alwasy exist ? Looks good
otherwise.
Siva
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]