Re: [evolution-patches] (groupwise) using GString
- From: Parthasarathi Susarla <sparthasarathi novell com>
- To: Sivaiah Nallagatla <snallagatla novell com>
- Cc: evolution-patches lists ximian com
- Subject: Re: [evolution-patches] (groupwise) using GString
- Date: Fri, 18 Mar 2005 11:24:50 +0530
committed.
Thanks.
-partha
On Thu, 2005-03-17 at 16:46 +0530, Sivaiah Nallagatla wrote:
> On Wed, 2005-03-16 at 15:40 +0530, Parthasarathi Susarla wrote:
> > + *str = g_strdup (gstr->str);
> > *len = strlen (*str) ;
>
> You need not calculate the stting length here, it is already part of
> Gstring struct. You are not checking for null checks for may values you
> retrieve from EGwItem. Are you sure they alwasy exist ? Looks good
> otherwise.
>
> Siva
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]