Re: [evolution-patches] Showing multiple alarm notifications in the same AlarmNotify dialogbox (after dobeys UI proposal)

[Philip Van Hoof <spamfrommailing freax org>]

On Thu, 2005-03-17 at 10:58 +0100, Rodrigo Moya wrote:
> On Mon, 2005-03-14 at 22:33 +0100, Philip Van Hoof wrote:
> > Hi there,
> > 
> > Dobey told me, on IRC, that he wasn't pleased with my userinterface.
> > So he proposed 
> > another one here
> > http://primates.ximian.com/~dobey/mockups/multi-alarm-mockup.png.
> > 
> > So while discussing this userinterface with him I moved around some
> > widgets and adapted
> > some code (like the treeview column renderer and content).
> > 
> > This new patch improves the userinterface.
> > 
> this looks good to me, and indeed was planning to do this exactly. Only
> one thing, which is that I wanted to do a little reorganization of the
> code in the alarm daemon, which I already started. If you give me a few
> days, I'll have it ready (probably in the weekend). For your code, I
> would really like to have the dialog in a separate file
> (AlarmNotificationDialog), with a simple set of API calls to add alarms
> to the dialog.
>
> So, if you could write that separate file, it would indeed help a lot
> with my new code. It would have to have those API calls
> (alarm_notification_dialog_show_alarm), and deal internally with the
> case where the alarms go to the system tray icon or to the dialog. Could
> you do that?


At this moment is the AlarmNotificationDialog implemented in alarm-notify-dialog.c

It contains the 

AlarmNotificationsDialog *notified_alarms_dialog_new (void)

And the

GtkTreeIter
add_alarm_to_notified_alarms_dialog (AlarmNotificationsDialog *na, time_t trigger,
                                time_t occur_start, time_t occur_end,
                                ECalComponentVType vtype, const char *summary,
                                const char *description, const char *location,
                                AlarmNotifyFunc func, gpointer func_data)



It isn't, however, a real GtkDialog inheritance. So you can't perform gtk_dialog_* (GTK_DIALOG(instance), ...)
functions on it, at this moment. But modifying doesn't sound very difficult. 

struct AlarmNotificationDialog
{
    GtkDialog dialog_private;
    ...
}

in stead of

struct AlarmNotificationDialog
{
    GtkDialog *dialog;
    ...
}

Etc etc etc ...


Perhaps it's better indeed to let it inherit from GtkDialog and to rename alarm-notify-dialog.c to
alarm-notification-dialog.c and make this a clean GtkWidget/GtkWindow/GtkDialog class.

The problem, however, is that I will be skiing in France this weekend. Starting tomorrow. So I can't work
on this during the weekend. If you, therefor, are going to do this yourself I hope my patch will help you
with this. :p

-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at freax dot org
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.freax.be, http://www.freax.eu.org