Re: [evolution-patches] Re: Exchange connector: Fix for 72041

[Sarfraaz Ahmed <asarfraaz novell com>]

Looks fine, commit with the changes mentioned below.

Thanks
-- Sarfraaz

On Thu, 2005-03-10 at 13:58 +0530, Sushma Rai wrote:
> Attached the patch with these changes..
> Please review.
>
> Thanks,
> Sushma.

text/plain attachment (task-crash-rev.diff)

Index: calendar/e-cal-backend-exchange-tasks.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/calendar/e-cal-backend-exchange-tasks.c,v
retrieving revision 1.13

>  
> +	/* Get the uid */
> +	temp_comp_uid = icalcomponent_get_uid (icalcomp);
> +	if (!temp_comp_uid) 
   free icalcomp here before returning.
> +		return GNOME_Evolution_Calendar_InvalidObject;
> +
>  
> Index: calendar/e-cal-backend-exchange-calendar.c
> ===================================================================
> RCS file: /cvs/gnome/evolution-exchange/calendar/e-cal-backend-exchange-calendar.c,v
> retrieving revision 1.36

>  	
> -	comp_uid = icalcomponent_get_uid (icalcomp);
> +	temp_comp_uid = icalcomponent_get_uid (icalcomp);
Do the same check as in tasks and free the icalcomp if uid is 0
>  	#if 0
>  	if (lookup_component (E_CAL_BACKEND_EXCHANGE (cbexc), comp_uid))
>  	{