[evolution-patches] Exchange connector: Fix for 72041



Hi,

This is the patch for crash during creation of tasks.
Please review.

Thanks,
Sushma.
Index: calendar/e-cal-backend-exchange-tasks.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/calendar/e-cal-backend-exchange-tasks.c,v
retrieving revision 1.13
diff -u -p -r1.13 e-cal-backend-exchange-tasks.c
--- calendar/e-cal-backend-exchange-tasks.c	18 Jan 2005 11:56:08 -0000	1.13
+++ calendar/e-cal-backend-exchange-tasks.c	9 Mar 2005 13:39:04 -0000
@@ -838,7 +838,7 @@ struct _cb_data {
 
 static ECalBackendSyncStatus
 create_task_object (ECalBackendSync *backend, EDataCal *cal,
-		    char **calobj, char **comp_uid)
+		    char **calobj, char **return_uid)
 {
 	ECalBackendExchangeTasks *ecalbextask;
 	ECalBackendExchange *ecalbex;
@@ -882,8 +882,14 @@ create_task_object (ECalBackendSync *bac
 
 	modtime = e2k_timestamp_from_icaltime (current);
 
+	/* Get the uid */
+       *return_uid = icalcomponent_get_uid (icalcomp);
+	if (!*return_uid) 
+		return GNOME_Evolution_Calendar_InvalidObject;
+
 	/* check if the object is already present in our cache */
-	if (e_cal_backend_exchange_in_cache (E_CAL_BACKEND_EXCHANGE (backend), *comp_uid, modtime, NULL)) {
+	if (e_cal_backend_exchange_in_cache (E_CAL_BACKEND_EXCHANGE (backend), 
+					     *return_uid, modtime, NULL)) {
 		icalcomponent_free (icalcomp);
 		return GNOME_Evolution_Calendar_ObjectIdAlreadyExists;
 	}	
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-exchange/ChangeLog,v
retrieving revision 1.289
diff -u -r1.289 ChangeLog
--- ChangeLog	9 Mar 2005 12:06:23 -0000	1.289
+++ ChangeLog	9 Mar 2005 13:39:15 -0000
@@ -1,3 +1,9 @@
+2005-03-09  Sushma Rai  <rsushma novell com>
+
+	* calendar/e-cal-backend-exchange-tasks.c (create_task_object): 
+	Reading the UID from icalcomp. Also changed the variable name from 
+	comp_uid to return_uid. Fixes #72041
+
 2005-03-09 Sivaiah Nallagatla <snallagatla novell com>
                                                                                            
         * addresbook/e-book-backend-exchange.c


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]