Re: [evolution-patches] Re: Exchange connector: Fix for 72041

[Sarfraaz Ahmed <asarfraaz novell com>]

On second thoughts, i think it would be more cleaner if you could use a local variable, comp_uid or some such, and finally dup it as return_uid at the end, once the object is successfully created on the server. That way you wont be returning the uid, in any fail case.

-- Sarfraaz

On Thu, 2005-03-10 at 10:52 +0530, Sarfraaz Ahmed wrote:

This looks fine, with one small change below. While you are at it, can you also fix this same problem in calendar as well?

Thanks
-- Sarfraaz

On Wed, 2005-03-09 at 19:19 +0530, Sushma Rai wrote:

Hi,

This is the patch for crash during creation of tasks.
Please review.

Thanks,
Sushma.

text/plain attachment (task-crash.diff)

Index: calendar/e-cal-backend-exchange-tasks.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/calendar/e-cal-backend-exchange-tasks.c,v
retrieving revision 1.13
diff -u -p -r1.13 e-cal-backend-exchange-tasks.c
--- calendar/e-cal-backend-exchange-tasks.c	18 Jan 2005 11:56:08 -0000	1.13
+++ calendar/e-cal-backend-exchange-tasks.c	9 Mar 2005 13:39:04 -0000
@@ -838,7 +838,7 @@ struct _cb_data {
 
 static ECalBackendSyncStatus
 create_task_object (ECalBackendSync *backend, EDataCal *cal,
-		    char **calobj, char **comp_uid)
+		    char **calobj, char **return_uid)
 {
 	ECalBackendExchangeTasks *ecalbextask;
 	ECalBackendExchange *ecalbex;
@@ -882,8 +882,14 @@ create_task_object (ECalBackendSync *bac
 
 	modtime = e2k_timestamp_from_icaltime (current);
 
+	/* Get the uid */
+       *return_uid = icalcomponent_get_uid (icalcomp);

You will have to dup this uid string.

+	if (!*return_uid) 
+		return GNOME_Evolution_Calendar_InvalidObject;
+