Re: [evolution-patches] Patch for bug#307780

[Not Zed <notzed ximian com>]

On Fri, 2005-07-22 at 15:56 +0530, Antony Vincent Pandian wrote:
> 
> On 7/21/05, Not Zed <notzed ximian com> wrote:
>         
>         Umm, since you already calculate is_visible, it would make
>         sense to use
>         it in the next line of code which implements the visibility,
>         right?
>         
>         Also the following code sets the bonobo-ui state, the thing is
>         it is in 
>         the listener function which just let you know of the state
>         change, so
>         there isn't any point setting the state in the ui, is there?
>         
>         And again, your patches should include the changelog changes
>         in the one
>         diff, No need to attach it separately.
> 
> ok. 
> 
> 
>         Instead of all that get_prop stuff (which isn't very
>         efficient), you
>         should just set the gconf key in the listener callback
>         instead.
> 
> ive used the get_prop stuff only while saving the visibility of the
> statusbar after closing evolution.
> 
> do you mean to say to save the state in the key each time the status
> is changed? or  use the EShellWindow to get the visibility of the
> status bar? or some other ....??

Yes, save it when it changes.  For various other reasons its better to
save straight away rather than wait till closing anyway.

>