Re: [evolution-patches] Shell : patch to have a component without buttons

[Sarfraaz Ahmed <asarfraaz novell com>]

Ping ? Is this fine to commit ?

-- Sarfraaz

On Fri, 2005-07-22 at 12:10 +0530, Sarfraaz Ahmed wrote:
> Thanks for the review comments.
> 
> I have removed the g_strdup of strings, and also the check for NULL
> bonobo controls.
> 
> I am attaching the new patch.
> 
> Please let me know if this is fine to commit.
> 
> On Thu, 2005-07-21 at 23:53 +0800, Not Zed wrote:
> > None of this change is necessary, g_strdup already does this null check.
> 
> > This bit here is the really only important bit, none of the other stuff
> > is strictly necessary (you could return empty controls, for instance).
> > 
> > +
> > +               if (!info->button_label || !info->menu_label)
> > +                       continue;
> > 
> > It saves a lot of changes I think.
> > 
> 
> It sure does. The whole patch is reduced to just 10 lines :)
> 
> > 
> 
> Thanks
> -- Sarfraaz
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches