Re: [evolution-patches] Patch for bug#307780

[Antony Vincent Pandian <santony gmail com>]

On 7/21/05, Not Zed <notzed ximian com> wrote:

Umm, since you already calculate is_visible, it would make sense to use
it in the next line of code which implements the visibility, right?

Also the following code sets the bonobo-ui state, the thing is it is in
the listener function which just let you know of the state change, so
there isn't any point setting the state in the ui, is there?

And again, your patches should include the changelog changes in the one
diff, No need to attach it separately.

ok.

Instead of all that get_prop stuff (which isn't very efficient), you
should just set the gconf key in the listener callback instead.

ive used the get_prop stuff only while saving the visibility of the statusbar after closing evolution.

do you mean to say to save the state in the key each time the status is changed? or  use the EShellWindow to get the visibility of the status bar? or some other ....??

On Thu, 2005-07-21 at 17:04 +0530, Antony Vincent Pandian wrote:
> +       is_visible = state[0] =='1';
> +
> +       if(*state == '0')
> +               gtk_widget_hide (status_bar);
> +       else
> +               gtk_widget_show (status_bar);

-- 
Luv,
S.Antony Vincent Pandian