Re: [evolution-patches] Patch for leaks in gtkhtml



tor, 07,.07.2005 kl. 23.40 +0800, skrev Not Zed:
> Since its getting a const in, you should definitely keep the strdup
> there.  e..g this would cause real problems if you ever set a const
> string as a value, which isn't entirely inconcievable.
> 
> Something calling that mustn't be freeing its value.
> 
Yeah, I'll see if it pops up again and then hunt for bad users.

> (wouldn't this change be spitting a warning about losing the const
> qualifier?).
> 
If I had compiled it it probably would :-)

The other fix was ok though?

Thanks for the feedback.

Cheers
Kjartan





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]