Re: [evolution-patches] e-url fix

[Rodrigo Moya <rodrigo novell com>]

On Tue, 2005-01-18 at 09:07 +0800, Not Zed wrote:
> 
> There's no reason for mail/ to use e-url at all, we just use camelurl
> whenever we need a url parsed.
> 
> Note that em-filter-source-element.c does actually use camelurl
> anyway, the e-url include should be removed.  It doesn't appear that
> mail-config.c uses the e-url it includes either.  Probably cruft left
> over from old code when someone unfamiliar with the codebase wrote
> something.
> 
right, sorry I didn't realize. So, since no one is using e-url, I've now
removed it from e-util, and committed the attached patch for mail.

Sarfraaz, does this fix the crash for connector?
> 
> 
-- 
Rodrigo Moya <rodrigo novell com>

? default/zh_CN/Makefile
? default/zh_CN/Makefile.in
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3533
diff -u -p -r1.3533 ChangeLog
--- ChangeLog	18 Jan 2005 06:09:31 -0000	1.3533
+++ ChangeLog	18 Jan 2005 13:18:49 -0000
@@ -1,3 +1,8 @@
+2005-01-18  Rodrigo Moya <rodrigo novell com>
+
+	* em-filter-source-element.c:
+	* mail-config.c: removed e-url.h include.
+
 2005-01-18  Not Zed  <NotZed Ximian com>
 
 	** See bug #70768.
Index: em-filter-source-element.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-filter-source-element.c,v
retrieving revision 1.2
diff -u -p -r1.2 em-filter-source-element.c
--- em-filter-source-element.c	3 Dec 2004 03:38:03 -0000	1.2
+++ em-filter-source-element.c	18 Jan 2005 13:18:49 -0000
@@ -31,7 +31,6 @@
 #include "em-filter-source-element.h"
 
 #include <gtk/gtk.h>
-#include <e-util/e-url.h>
 #include <libedataserver/e-sexp.h>
 #include <libedataserver/e-account-list.h>
 #include <camel/camel-url.h>
Index: mail-config.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-config.c,v
retrieving revision 1.312
diff -u -p -r1.312 mail-config.c
--- mail-config.c	19 Oct 2004 06:35:44 -0000	1.312
+++ mail-config.c	18 Jan 2005 13:18:49 -0000
@@ -54,7 +54,6 @@
 #include <gal/util/e-util.h>
 #include <gal/widgets/e-gui-utils.h>
 
-#include <e-util/e-url.h>
 #include <e-util/e-passwords.h>
 #include <e-util/e-account-list.h>
 #include <e-util/e-signature-list.h>