[evolution-patches] patches to fix some a11y bugs

[Li Yuan <Li Yuan Sun COM>]

Hi, Rodrigo

Here are two patches for some evolution a11y bugs.
Please help me to review it.

Thank you very much.

Regards,
Li

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2619
diff -u -r1.2619 ChangeLog
--- ChangeLog	17 Jan 2005 09:21:35 -0000	1.2619
+++ ChangeLog	18 Jan 2005 09:44:42 -0000
@@ -1,3 +1,12 @@
+2005-01-18  Li Yuan  <li yuan sun com>
+
+	* gui/dialogs/task-details-page.c: (get_widgets):
+	add a11y name to url.
+	* gui/dialogs/task-details-page.glade:
+	add a11y name to date completed.
+	* gui/dialogs/task-page.glade:
+	add a11y names to due date and start date.
+
 2005-01-17  Harish Krishnaswamy  <kharish novell com>
 
 	* gui/dialogs/cal-attachment-bar.c (destroy):
Index: gui/dialogs/task-details-page.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-details-page.c,v
retrieving revision 1.44
diff -u -r1.44 task-details-page.c
--- gui/dialogs/task-details-page.c	14 Oct 2004 14:22:12 -0000	1.44
+++ gui/dialogs/task-details-page.c	18 Jan 2005 09:44:59 -0000
@@ -31,6 +31,8 @@
 #include <glade/glade.h>
 #include <widgets/misc/e-dateedit.h>
 #include <widgets/misc/e-url-entry.h>
+#include <atk/atkobject.h>
+#include <glib/gi18n.h>
 #include "e-util/e-dialog-widgets.h"
 #include "../calendar-config.h"
 #include "../e-timezone-entry.h"
@@ -484,6 +486,7 @@
 	TaskDetailsPagePrivate *priv;
 	GSList *accel_groups;
 	GtkWidget *toplevel;
+	AtkObject *a11y;
 
 	priv = tdpage->priv;
 
@@ -519,6 +522,9 @@
 	priv->url_entry = GW ("url_entry");
 	gtk_widget_show (priv->url_entry);
 	priv->url = e_url_entry_get_entry (E_URL_ENTRY (priv->url_entry));
+	a11y = gtk_widget_get_accessible (priv->url);
+	if (a11y != NULL)
+		atk_object_set_name (a11y, _("Web Page"));
 	
 #undef GW
 
Index: gui/dialogs/task-details-page.glade
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-details-page.glade,v
retrieving revision 1.21
diff -u -r1.21 task-details-page.glade
--- gui/dialogs/task-details-page.glade	22 Dec 2004 07:08:40 -0000	1.21
+++ gui/dialogs/task-details-page.glade	18 Jan 2005 09:45:03 -0000
@@ -316,6 +316,9 @@
 		  <property name="int1">0</property>
 		  <property name="int2">0</property>
 		  <property name="last_modification_time">Fri, 01 Jun 2001 18:58:51 GMT</property>
+		  <accessibility>
+		    <atkrelation target="date_completed_label" type="labelled-by"/>
+		  </accessibility>
 		</widget>
 		<packing>
 		  <property name="left_attach">1</property>
Index: gui/dialogs/task-page.glade
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-page.glade,v
retrieving revision 1.35
diff -u -r1.35 task-page.glade
--- gui/dialogs/task-page.glade	10 Jan 2005 13:36:50 -0000	1.35
+++ gui/dialogs/task-page.glade	18 Jan 2005 09:45:36 -0000
@@ -489,6 +489,9 @@
 		      <property name="int1">0</property>
 		      <property name="int2">0</property>
 		      <property name="last_modification_time">Mon, 14 Jun 2004 18:16:07 GMT</property>
+		      <accessibility>
+			<atkrelation target="due-date-label" type="labelled-by"/>
+		      </accessibility>
 		    </widget>
 		    <packing>
 		      <property name="padding">0</property>
@@ -504,9 +507,6 @@
 		      <property name="int1">0</property>
 		      <property name="int2">0</property>
 		      <property name="last_modification_time">Tue, 19 Jun 2001 04:43:54 GMT</property>
-		      <accessibility>
-			<atkrelation target="due-date-label" type="labelled-by"/>
-		      </accessibility>
 		    </widget>
 		    <packing>
 		      <property name="padding">0</property>
@@ -538,6 +538,9 @@
 		      <property name="int1">0</property>
 		      <property name="int2">0</property>
 		      <property name="last_modification_time">Mon, 14 Jun 2004 18:16:13 GMT</property>
+		      <accessibility>
+			<atkrelation target="start-date-label" type="labelled-by"/>
+		      </accessibility>
 		    </widget>
 		    <packing>
 		      <property name="padding">0</property>
@@ -553,9 +556,6 @@
 		      <property name="int1">0</property>
 		      <property name="int2">0</property>
 		      <property name="last_modification_time">Tue, 19 Jun 2001 04:43:46 GMT</property>
-		      <accessibility>
-			<atkrelation target="start-date-label" type="labelled-by"/>
-		      </accessibility>
 		    </widget>
 		    <packing>
 		      <property name="padding">0</property>

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/misc/ChangeLog,v
retrieving revision 1.343
diff -u -r1.343 ChangeLog
--- ChangeLog	17 Jan 2005 08:56:49 -0000	1.343
+++ ChangeLog	18 Jan 2005 09:42:42 -0000
@@ -1,3 +1,8 @@
+2005-01-18  Li Yuan  <li yuan sun com>
+
+	* e-url-entry.c: (init):
+	add a11y name to url link button.
+
 2005-01-17  Harry Lu  <harry lu sun com>
 
 	Fix for 62831.
Index: e-url-entry.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/misc/e-url-entry.c,v
retrieving revision 1.12
diff -u -r1.12 e-url-entry.c
--- e-url-entry.c	26 Nov 2004 15:15:36 -0000	1.12
+++ e-url-entry.c	18 Jan 2005 09:42:42 -0000
@@ -27,6 +27,8 @@
 
 #include <gtk/gtk.h>
 #include <libgnome/gnome-url.h>
+#include <atk/atkobject.h>
+#include <glib/gi18n.h>
 #include "e-url-entry.h"
 #include <e-util/e-icon-factory.h>
 
@@ -94,6 +96,7 @@
 {
 	EUrlEntryPrivate *priv;
 	GtkWidget *pixmap;
+	AtkObject *a11y;
 
 	priv = g_new0 (EUrlEntryPrivate, 1);
 	url_entry->priv = priv;
@@ -103,6 +106,10 @@
 	priv->button = gtk_button_new ();
 	gtk_widget_set_sensitive (priv->button, FALSE);
 	gtk_box_pack_start (GTK_BOX (url_entry), priv->button, FALSE, FALSE, 0);
+	a11y = gtk_widget_get_accessible (priv->button);
+	if (a11y != NULL) {
+		atk_object_set_name (a11y, _("click here to go to url"));
+	}
 	pixmap = e_icon_factory_get_image ("stock_connect-to-url", E_ICON_SIZE_BUTTON);
 	gtk_container_add (GTK_CONTAINER (priv->button), pixmap);
 	gtk_widget_show (pixmap);