Re: [evolution-patches] e-url fix



Rodrigo Moya wrote:

On Tue, 2005-01-18 at 09:07 +0800, Not Zed wrote:
There's no reason for mail/ to use e-url at all, we just use camelurl
whenever we need a url parsed.

Note that em-filter-source-element.c does actually use camelurl
anyway, the e-url include should be removed.  It doesn't appear that
mail-config.c uses the e-url it includes either.  Probably cruft left
over from old code when someone unfamiliar with the codebase wrote
something.

right, sorry I didn't realize. So, since no one is using e-url, I've now
removed it from e-util, and committed the attached patch for mail.

Sarfraaz, does this fix the crash for connector?
Yes, tested with this patch. The crash is fixed.

The main reason i found for this was that exchange linked to eshell as well as libedataserver and both of these had the e_uri_new symbol defined. And e-data-cal-factory:lookup_backend() was resolving the e_uri_new symbol from eshell instead of edataserver. Though this fixes the bug for e_uri_* methods, would it be a good idea for the e-d-s libraries to have -Bsymbolic in their linker flags? Other apps might face such problems.

--Sarfraaz



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]