[evolution-patches] Suspected typo in connector: camel_exchange_folder: cache_xfer



Looks like a simple typo in cache_xfer; this is called by
transfer_messages_to with "delete" of FALSE, but "remove" is used for
the test instead; unfortunately it's the name of a function, hence gets
treated as a function pointer, which is a non-NULL pointer, and hence is
TRUE when treated as a boolean.

I haven't looked into the impact of this, but it looks like a simple
typo, and, err... "it compiles"...

Hopefully the maintainer can comment?

Dave
Index: camel-exchange-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/camel/camel-exchange-folder.c,v
retrieving revision 1.5
diff -u -p -r1.5 camel-exchange-folder.c
--- camel-exchange-folder.c	19 Aug 2004 06:03:58 -0000	1.5
+++ camel-exchange-folder.c	1 Sep 2004 23:38:11 -0000
@@ -612,7 +612,7 @@ cache_xfer (CamelExchangeFolder *stub_so
 		}
 		camel_object_unref (CAMEL_OBJECT (src));
 
-		if (remove) {
+		if (delete) {
 			camel_data_cache_remove (stub_source->cache, "cache",
 						 src_uids->pdata[i], NULL);
 		}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]