Re: [evolution-patches] Suspected typo in connector: camel_exchange_folder: cache_xfer
- From: Dan Winship <danw novell com>
- To: David Malcolm <dmalcolm redhat com>
- Cc: evolution-patches ximian com
- Subject: Re: [evolution-patches] Suspected typo in connector: camel_exchange_folder: cache_xfer
- Date: Fri, 03 Sep 2004 16:02:23 -0400
On Wed, 2004-09-01 at 19:49 -0400, David Malcolm wrote:
> Looks like a simple typo in cache_xfer; this is called by
> transfer_messages_to with "delete" of FALSE, but "remove" is used for
> the test instead; unfortunately it's the name of a function, hence gets
> treated as a function pointer, which is a non-NULL pointer, and hence is
> TRUE when treated as a boolean.
>
> I haven't looked into the impact of this, but it looks like a simple
> typo, and, err... "it compiles"...
>
> Hopefully the maintainer can comment?
Yup, it's a bug. Please commit the fix (with a ChangeLog entry) to HEAD.
(Given that the bug was there in 1.4 too, I don't think it's worth
breaking the code freeze on 2.0.0 for.)
-- Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]