Re: [evolution-patches] fix for bug #63377 (crashes when replying to a certain message)

[Not Zed <notzed ximian com>]

please add a comment to the code in message_to_html to the effect of

/* FIXME: we should be getting this from the current view, not the global setting. */

The setting is actually bad now since you can't look at different widnows with different settings, they will be forced onto every open window when it changes.  Otherwise the  fix is good.

On Wed, 2004-09-01 at 15:51 -0400, Jeffrey Stedfast wrote:
> When replying to messages, the EMFormat *source pointer is non-NULL but
> the ::clone() method doesn't copy it over to the emfq object (in my
> case ::charset is NULL and ::default_charset is UTF-8) and so we end up
> trying to create a charset filter from NULL to UTF-8, which of course
> fails. Since no charset conversion ends up being done, we end up passing
> raw binary garbage to the e_trie_search() function in the tohtml filter
> and it crashes.

This is a bug in e-trie-search which must be fixed.  Unlike glib, evolution-mail code must handle invalid utf8 it receives (without an overly expensive and useless validate-and-fail-completely check), and it is probably still possible to hit this case by sending an appropriately formed message (i imagine at least some if not all iconv's created to convert utf-8 to utf-8 noop, if we don't already noop ourselves, which i think we do).

Can you please attach a properly symboled backtrace of the original crash to the bug so the real source of the issue can be traced and fixed?

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer