Re: [evolution-patches] evolution/cal gui patch for resource booking



Hi,

This is the new patch with the changes pointed out.

since the "Unable to book" part is shown to the user, it should be
marked for translation.


Also, the error_str is g_free'd in the wrong spot, it should be declared
and free'd inside the 'if (error->code != E_CALENDAR_STATUS_OK... block.


            Thanks
                                        -- Sarfraaz Ahmed <asarfraaz novell com>
Index: gui/itip-utils.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/itip-utils.c,v
retrieving revision 1.90.14.3
diff -u -p -u -p -r1.90.14.3 itip-utils.c
--- gui/itip-utils.c	6 Oct 2004 14:19:23 -0000	1.90.14.3
+++ gui/itip-utils.c	8 Oct 2004 12:37:50 -0000
@@ -539,15 +539,18 @@ comp_server_send (ECalComponentItipMetho
 	icalcomponent *top_level, *returned_icalcomp = NULL;
 	gboolean retval = TRUE;
 	GError *error = NULL;
+	gchar *error_str;
 	
 	top_level = comp_toplevel_with_zones (method, comp, client, zones);
 	if (!e_cal_send_objects (client, top_level, users, &returned_icalcomp, &error)) {
 		/* FIXME Really need a book problem status code */
 		if (error->code != E_CALENDAR_STATUS_OK) {
 			/* FIXME Better error message */
-			e_notice (NULL, GTK_MESSAGE_ERROR, "Unable to book");
+			error_str = g_strdup_printf (_("Unable to book : %s"), e_cal_get_error_message (error->code));
+			e_notice (NULL, GTK_MESSAGE_ERROR, error_str);
 			
 			retval = FALSE;
+			g_free (error_str);
 		}
 	}
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]