Re: [evolution-patches] Revised mailing list actions plugin

[Meilof Veeningen <meilof wanadoo nl>]

Not Zed wrote:

> The button order is also wrong, cancel should be to the left, iirc, 
> e.g. Cancel Edit Send

OK, from the mail dialogs, you're right, so I fixed it. But Evolution is 
not entirely consistent on this; when you try to delete an account, the 
confirmation dialog is "Delete - Don't delete".

> And one more change (ok so it wasn't all right afterall :), the "list" 
> menu item is still at the bottom, it should be in the reply block or 
> the second to last block.  Maybe the reply block is a good place to 
> put it.

Trouble is, there is no placeholder to place it in the reply block. 
Basically there are two placeholders, MailMessagections and 
MailListActions. The former is just above the reply block, and since the 
"Save attachments" plugin also resides there, I put it there in this 
patch; the latter seems appropriately named but oddly only contains the 
"Expunge" men item.

BTW, I noted the "visible" property doesn't seem to work currently: the 
mailing list actions menu items currently always show up...

And in the message view (i.e. when double-clicking a message), the 
"Action" menu still shows up first before the "File", etc. menus. I 
found adding the following to the menu XML:

>     <submenu name="File"/>
>     <placeholder name="EditPlaceholder">
>       <submenu name="Edit" _label="_Edit">
>       </submenu>
>     </placeholder>
>     <submenu name="View"/>

solves this, but that seems like a very bad idea. Don't know what else 
can be done about this.

> 1. The 'description' property is incorrect, in the manual it was 
> always properly a separate element inside the <e-plugin> one, rather 
> than a property on it, so you have to fix them up so it gets loaded 
> properly.
> 2. There is a new 'author' element for use inside the e-plugin tag, 
> <author name="foo" email="bar baz <mailto:bar baz>"/>, it can occur 
> multiple times, and either name or email can be omitted.

Added these, too.


Meilof
-- meilof wanadoo nl

? Makefile
? Makefile.in
? eplug-mailing-list-actions-patch1
? org-gnome-mailing-list-actions.eplug
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/ChangeLog,v
retrieving revision 1.1
diff -r1.1 ChangeLog
0a1,12
> 2004-11-04  Meilof Veeningen  <meilof wanadoo nl>
> 
> 	* org-gnome-mailing-list-actions.eplug.in: Added author tag, fixed
> 	description, removed "plugin" from name, changed position of item
> 	in popup menu
> 
> 	* org-gnome-mailing-list-actions.xml: Now place menus in
> 	MailMessageActions placeholder; moved label to <commands> section
> 
> 	* org-gnome-mailing-list-actions-errors.xml: fixed button order:
> 	"Cancel" now leftmost button
> 
Index: org-gnome-mailing-list-actions-errors.xml
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions-errors.xml
19,20d18
<   <button label="_Send message" response="GTK_RESPONSE_YES"/>
<   <button label="_Edit message" response="GTK_RESPONSE_NO"/>
21a20,21
>   <button label="_Edit message" response="GTK_RESPONSE_NO"/>
>   <button label="_Send message" response="GTK_RESPONSE_YES"/>
Index: org-gnome-mailing-list-actions-errors.xml.h
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml.h,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions-errors.xml.h
15d14
< char *s = N_("_Send message");
16a16
> char *s = N_("_Send message");
Index: org-gnome-mailing-list-actions.eplug.in
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions.eplug.in,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions.eplug.in
8,9c8,10
< 		name="Mailing List Actions plugin"
< 		description="Provide actions for common mailing list commands (subscribe, unsubscribe, ...)">
---
> 		name="Mailing List Actions">
> 		<author name="Meilof Veeningen" email="meilof wanadoo nl"/>
> 		<description>Provide actions for common mailing list commands such as subscribing, unsubscribing and posting to the mailing list</description>
31,39c32,39
< 			<menu id="org.gnome.mail.folderview.popup.select" target="select">
< 				<item type="bar" path="96.list" visible="mailing_list" activate=""/>
< 				<item type="submenu" path="96.list.00" visible="mailing_list" activate="" label="Mailing _List"/>
< 				<item type="item" verb="ListHelp" path="96.list.00/00.help" label="Get list _usage information" visible="mailing_list" activate="emla_list_help"/>
< 				<item type="item" verb="ListSubscribe" path="96.list.00/10.subscribe" label="_Subscribe to list" visible="mailing_list" activate="emla_list_subscribe"/>
< 				<item type="item" verb="ListUnsubscribe" path="96.list.00/20.unsubscribe" label="_Un-subscribe to list" visible="mailing_list" activate="emla_list_unsubscribe"/>
< 				<item type="item" verb="ListPost" path="96.list.00/30.post" label="_Post message to list" visible="mailing_list" activate="emla_list_post"/>
< 				<item type="item" verb="ListOwner" path="96.list.00/40.owner" label="Contact list _owner" visible="mailing_list" activate="emla_list_owner"/>
< 				<item type="item" verb="ListArchive" path="96.list.00/50.archive" label="Get list _archive" visible="mailing_list" activate="emla_list_archive"/>
---
> 			<menu id="org.gnome.evolution.mail.folderview.popup" target="select">
> 				<item type="submenu" path="20.emfv.50" visible="mailing_list" activate="" label="Mailing _List"/>
> 				<item type="item" verb="ListHelp" path="20.emfv.50/00.help" label="Get list _usage information" visible="mailing_list" activate="emla_list_help"/>
> 				<item type="item" verb="ListSubscribe" path="20.emfv.50/10.subscribe" label="_Subscribe to list" visible="mailing_list" activate="emla_list_subscribe"/>
> 				<item type="item" verb="ListUnsubscribe" path="20.emfv.50/20.unsubscribe" label="_Un-subscribe to list" visible="mailing_list" activate="emla_list_unsubscribe"/>
> 				<item type="item" verb="ListPost" path="20.emfv.50/30.post" label="_Post message to list" visible="mailing_list" activate="emla_list_post"/>
> 				<item type="item" verb="ListOwner" path="20.emfv.50/40.owner" label="Contact list _owner" visible="mailing_list" activate="emla_list_owner"/>
> 				<item type="item" verb="ListArchive" path="20.emfv.50/50.archive" label="Get list _archive" visible="mailing_list" activate="emla_list_archive"/>
Index: org-gnome-mailing-list-actions.xml
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions.xml,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions.xml
3,8c3,8
<     <cmd name="ListHelp" _tip="Get information about the usage of the list this message belongs to"/>
<     <cmd name="ListSubscribe" _tip="Subscribe to the mailing list this message belongs to"/>
<     <cmd name="ListUnsubscribe" _tip="Unsubscribe to the mailing list this message belongs to"/>
<     <cmd name="ListPost" _tip="Post a message to the mailing list this message belongs to"/>
<     <cmd name="ListOwner" _tip="Contact the owner of the mailing list this message belongs to"/>
<     <cmd name="ListArchive" _tip="Get an archive of the list this message belongs to"/>
---
>     <cmd name="ListHelp"  _label="Get list _usage information" _tip="Get information about the usage of the list this message belongs to"/>
>     <cmd name="ListSubscribe" _label="_Subscribe to list" _tip="Subscribe to the mailing list this message belongs to"/>
>     <cmd name="ListUnsubscribe" _label="_Un-subscribe to list" _tip="Unsubscribe to the mailing list this message belongs to"/>
>     <cmd name="ListPost" _label="_Post message to list" _tip="Post a message to the mailing list this message belongs to"/>
>     <cmd name="ListOwner" _label="Contact list _owner" _tip="Contact the owner of the mailing list this message belongs to"/>
>     <cmd name="ListArchive" _label="Get list _archive" _tip="Get an archive of the list this message belongs to"/>
13,20c13,24
<       <submenu name="List" _label="Mailing _List">    
<         <menuitem verb="ListHelp" _label="Get list _usage information"/>
<         <menuitem verb="ListSubscribe" _label="_Subscribe to list"/>
<         <menuitem verb="ListUnsubscribe" _label="_Un-subscribe to list"/>
<         <menuitem verb="ListPost" _label="_Post message to list"/>
<         <menuitem verb="ListOwner" _label="Contact list _owner"/>
<         <menuitem verb="ListArchive" _label="Get list _archive"/>
<       </submenu>
---
>       <placeholder name="ComponentActionsPlaceholder">
>         <placeholder name="MailMessageActions">
>           <submenu name="List" _label="Mailing _List">    
>             <menuitem name="ListHelp" verb=""/>
>             <menuitem name="ListSubscribe" verb=""/>
>             <menuitem name="ListUnsubscribe" verb=""/>
>             <menuitem name="ListPost" verb=""/>
>             <menuitem name="ListOwner" verb=""/>
>             <menuitem name="ListArchive" verb=""/>
>           </submenu>
>         </placeholder>
>       </placeholder>