Re: [evolution-patches] Revised mailing list actions plugin

[Not Zed <notzed ximian com>]

On Thu, 2004-11-04 at 22:04 +0100, Meilof Veeningen wrote:
> Not Zed wrote:
>
> > The button order is also wrong, cancel should be to the left, iirc, 
> > e.g. Cancel Edit Send
>
> OK, from the mail dialogs, you're right, so I fixed it. But Evolution is 
> not entirely consistent on this; when you try to delete an account, the 
> confirmation dialog is "Delete - Don't delete".
Yeah, they're not all correct :)
> > And one more change (ok so it wasn't all right afterall :), the "list" 
> > menu item is still at the bottom, it should be in the reply block or 
> > the second to last block.  Maybe the reply block is a good place to 
> > put it.
>
> Trouble is, there is no placeholder to place it in the reply block. 
> Basically there are two placeholders, MailMessagections and 
> MailListActions. The former is just above the reply block, and since the 
> "Save attachments" plugin also resides there, I put it there in this 
> patch; the latter seems appropriately named but oddly only contains the 
> "Expunge" men item.
Well we can add placeholders to the main xml files if we need to.  Sounds like we do, as part of the 'plugin instrumentation' process.
> BTW, I noted the "visible" property doesn't seem to work currently: the 
> mailing list actions menu items currently always show up...
It isn't implemented at all for bonobo menu's currently.  I'm not sure how easy it is to hook up, so use 'enable' for now. (none of the other bonobo menu's in evolution-mail at least ever get hidden, they only ever get disabled, popup menu's are different).
> And in the message view (i.e. when double-clicking a message), the 
> "Action" menu still shows up first before the "File", etc. menus. I 
> found adding the following to the menu XML:
>
> >     <submenu name="File"/>
> >     <placeholder name="EditPlaceholder">
> >       <submenu name="Edit" _label="_Edit">
> >       </submenu>
> >     </placeholder>
> >     <submenu name="View"/>
>
> solves this, but that seems like a very bad idea. Don't know what else 
> can be done about this.
Thats very strange.  Can you use a *different* bonobo xml file for that menu instead?

Although they should really be fixed up to work the same.
> > 1. The 'description' property is incorrect, in the manual it was 
> > always properly a separate element inside the <e-plugin> one, rather 
> > than a property on it, so you have to fix them up so it gets loaded 
> > properly.
> > 2. There is a new 'author' element for use inside the e-plugin tag, 
> > <author name="foo" email="bar baz <mailto:bar baz>"/>, it can occur 
> > multiple times, and either name or email can be omitted.
>
> Added these, too.

Cool, this patch looks ok to go in.

--

Michael Zucchi <notzed ximian com> "I'm stuck in a reality I can't imagine could be real." Novell's Evolution and Free Software Developer