Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)

[JP Rosevear <jpr ximian com>]

On Mon, 2004-03-15 at 11:08, Not Zed wrote:
> Ok for the mailer part:
> 
>  - don't use gchar, use char.
>  - is gnome icon theme lookup filename thread-safe?  If not, it cannot
> be used from em-format-*.c, as this code is always run in another
> thread.
>  - you removed one of the icons, the no-key icon.  it shouldn't be
> blank.  (pgp-signature-nokey.png)
>  - the formatting should be k&r style.
>  - dont break the spelling in comments, if you don't mind.
> 
> Is there any way to lookup icons that aren't in the theme?  Having every
> icon in the theme might be unecessarily burdonsome during development at
> least, if not beyond.

Good thought, we could probably install the art/ dir in a manner
consistent with the icon theme, ie
<prefix>/share/evolution/icon-theme/16x16 or whatever and the e-icon
code can fall through to there first.

Other than that, I'll try out the patch tomorrow.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.