Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)

[Not Zed <notzed ximian com>]

Ok for the mailer part:

 - don't use gchar, use char.
 - is gnome icon theme lookup filename thread-safe?  If not, it cannot
be used from em-format-*.c, as this code is always run in another
thread.
 - you removed one of the icons, the no-key icon.  it shouldn't be
blank.  (pgp-signature-nokey.png)
 - the formatting should be k&r style.
 - dont break the spelling in comments, if you don't mind.

Is there any way to lookup icons that aren't in the theme?  Having every
icon in the theme might be unecessarily burdonsome during development at
least, if not beyond.

On Fri, 2004-03-12 at 14:23 -0500, Michael Terry wrote:

> OK.  There was some delay on this patch while we tried to get all the
> icons into gnome-icon-theme.  (Stop making new icons, people!  :))
> 
> I have updated the patch to work with CVS HEAD code.  I have attached
> the new patch and reattached the files e-icon-factory.{c,h}.
> 
> A reminder: This patch aims to convert Evolution from built-in icons to
> using the gnome-icon-theme.  It moves e-icon-factory from a shell
> service to an evolution-wide e-util service.  *All* icons are generated
> by calling the e_icon_factory_get_icon* family.
> 
> After applying this patch, you will need to add the attached
> e-icon-factory files into e-util directory and remove them from the
> shell directory.  You may also remove all the icons in art/ that are no
> longer used (almost all of them -- look at the patch for
> art/Makefile.am).
> 
> This means that all further new icons will need to be added to
> gnome-icon-theme rather than into the art/ directory.
> 
> Let me know if anything needs to be changed!
> 
> Note: There are still a couple missing icons -- "im" and "im-nov".  See
> bug #129294 for progress on that.  In addition, all icons in the art/
> directory that are not being used are no longer represented.  You'll
> have to go through gnome-icon-theme after this.
> 
> -mt