Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)

[JP Rosevear <jpr ximian com>]

On Fri, 2004-03-12 at 14:23, Michael Terry wrote:
> OK.  There was some delay on this patch while we tried to get all the
> icons into gnome-icon-theme.  (Stop making new icons, people!  :))
> 
> I have updated the patch to work with CVS HEAD code.  I have attached
> the new patch and reattached the files e-icon-factory.{c,h}.
> 
> A reminder: This patch aims to convert Evolution from built-in icons to
> using the gnome-icon-theme.  It moves e-icon-factory from a shell
> service to an evolution-wide e-util service.  *All* icons are generated
> by calling the e_icon_factory_get_icon* family.
> 
> After applying this patch, you will need to add the attached
> e-icon-factory files into e-util directory and remove them from the
> shell directory.  You may also remove all the icons in art/ that are no
> longer used (almost all of them -- look at the patch for
> art/Makefile.am).
> 
> This means that all further new icons will need to be added to
> gnome-icon-theme rather than into the art/ directory.
> 
> Let me know if anything needs to be changed!
> 
> Note: There are still a couple missing icons -- "im" and "im-nov".  See
> bug #129294 for progress on that.  In addition, all icons in the art/
> directory that are not being used are no longer represented.  You'll
> have to go through gnome-icon-theme after this.

Earlier this week I built and ran the patch and it all seems to work. 
One thing, you hardcoded the menu icon size to 16 instead of using the
Gtk+ define that was already in the code.

Also any thoughts about the suggestion of falling back to
/usr/share/evolution?

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.