Re: [evolution-patches] seeking patch review for bug 55018

[Not Zed <notzed ximian com>]

On Wed, 2004-03-03 at 17:33 +0800, Calvin Liu wrote:

> It's for trunk, maybe 1.4.x. I haven't try 1.5 yet. Don't know it has
> the same problem.
> 
> I know that something wrong with the url parser, but as you can see,
> it's a cheap, no harm workaround.

I doubt anything is wrong with the url parser, but not all the code uses
it - is the problem :)

For 1.5 (trunk, head, etc), we should track down where these problems
exist, and try and fix them.  There are still some characters that are
illegal in certain cases, but these should be handled where appropriate
(e.g. imap, you can't use . on some servers, but only the imap code
knows that).

e.g. places where url's are made by using g_strdup_printf, url's are
parsed using strchr, etc.  Many parts of the code suffer from this
problem.

Fixes like this will just hide the bugs.

 Michael