[evolution-patches] seeking patch review for bug 55018

[Calvin Liu <calvin liu sun com>]

Hi, there,

This bug will affect all platforms. If the mail folder name contains
"%", the folder name will be changed.

Please review it.

Thanks.
Calvin

Index: evolution/shell/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/shell/ChangeLog,v
retrieving revision 1.1400
diff -u -r1.1400 ChangeLog
--- evolution/shell/ChangeLog	25 Feb 2004 18:37:53 -0000	1.1400
+++ evolution/shell/ChangeLog	3 Mar 2004 09:11:08 -0000
@@ -1,3 +1,8 @@
+2004-03-03  Calvin Liu <calvin liu sun com>
+	* e-shell-utils.c: change mail_folder_name_is_valid(),
+	add '%' to invalid char list
+	fixes bug 55018
+
 2004-02-15  Rodney Dawes  <dobey ximian com>
 
 	* evolution-nognome.in: Use @BASE_VERSION@ for the binary
Index: evolution/shell/e-shell-utils.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/e-shell-utils.c,v
retrieving revision 1.13
diff -u -r1.13 e-shell-utils.c
--- evolution/shell/e-shell-utils.c	6 Mar 2003 19:32:46 -0000	1.13
+++ evolution/shell/e-shell-utils.c	3 Mar 2004 09:11:26 -0000
@@ -136,6 +136,12 @@
 		return FALSE;
 	}
 
+	if (strchr (name, '%') != NULL) {
+		if (reason_return != NULL)
+			*reason_return = _("Folder name cannot contain the character \"%\".");
+		return FALSE;
+	}
+
 	if (strcmp (name, ".") == 0 || strcmp (name, "..") == 0) {
 		if (reason_return != NULL)
 			*reason_return = _("'.' and '..' are reserved folder names.");