Re: [evolution-patches] [gal] fix compile error exposed by gcc 3.4.0

[Not Zed <notzed ximian com>]

looks good, please commit

On Thu, 2004-06-10 at 19:33 -0400, Jon Oberheide wrote:
> Greetings,
>
> While compiling the latest CVS gal, the following warnings appear when
> compiling with gcc 3.3.3:
>   gal-a11y-e-table-item.c: In function `eti_ref_at':
>   gal-a11y-e-table-item.c:300: warning: assignment makes pointer from
> integer without a cast
>   gal-a11y-e-table-item.c: At top level:
>   gal-a11y-e-table-item.c:688: warning: `eti_reinit_data' was declared
> implicitly `extern' and later `static'
>   gal-a11y-e-table-item.c:300: warning: previous declaration of
> `eti_reinit_data'
>   gal-a11y-e-table-item.c:688: warning: type mismatch with previous
> implicit declaration
>   gal-a11y-e-table-item.c:300: warning: previous implicit declaration of
> `eti_reinit_data'
>   gal-a11y-e-table-item.c:688: warning: `eti_reinit_data' was previously
> implicitly declared to return `int'
>   gal-a11y-e-table-item.c: In function `eti_a11y_cursor_changed_cb':
>
> While compiling the same code with gcc 3.4.0, it results in an error
> instead of simply a warning:
>   gal-a11y-e-table-item.c: In function `eti_ref_at':
>   gal-a11y-e-table-item.c:300: warning: assignment makes pointer from
> integer without a cast
>   gal-a11y-e-table-item.c: At top level:
>   gal-a11y-e-table-item.c:688: error: conflicting types for
> 'eti_reinit_data'
>   gal-a11y-e-table-item.c:300: error: previous implicit declaration of
> 'eti_reinit_data' was here
>   gal-a11y-e-table-item.c: In function `eti_a11y_cursor_changed_cb':
>
> The errors and warnings are resolved for both 3.3.3 and 3.4.0 with a
> simple forward declaration of eti_reinit_data.  The patch is attached.
>
> Regards,
> Jon Oberheide

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer