Greetings, While compiling the latest CVS gal, the following warnings appear when compiling with gcc 3.3.3: gal-a11y-e-table-item.c: In function `eti_ref_at': gal-a11y-e-table-item.c:300: warning: assignment makes pointer from integer without a cast gal-a11y-e-table-item.c: At top level: gal-a11y-e-table-item.c:688: warning: `eti_reinit_data' was declared implicitly `extern' and later `static' gal-a11y-e-table-item.c:300: warning: previous declaration of `eti_reinit_data' gal-a11y-e-table-item.c:688: warning: type mismatch with previous implicit declaration gal-a11y-e-table-item.c:300: warning: previous implicit declaration of `eti_reinit_data' gal-a11y-e-table-item.c:688: warning: `eti_reinit_data' was previously implicitly declared to return `int' gal-a11y-e-table-item.c: In function `eti_a11y_cursor_changed_cb': While compiling the same code with gcc 3.4.0, it results in an error instead of simply a warning: gal-a11y-e-table-item.c: In function `eti_ref_at': gal-a11y-e-table-item.c:300: warning: assignment makes pointer from integer without a cast gal-a11y-e-table-item.c: At top level: gal-a11y-e-table-item.c:688: error: conflicting types for 'eti_reinit_data' gal-a11y-e-table-item.c:300: error: previous implicit declaration of 'eti_reinit_data' was here gal-a11y-e-table-item.c: In function `eti_a11y_cursor_changed_cb': The errors and warnings are resolved for both 3.3.3 and 3.4.0 with a simple forward declaration of eti_reinit_data. The patch is attached. Regards, Jon Oberheide -- Jon Oberheide <jon focalhost com> GnuPG Key: 1024D/0CF1526D Fingerprint: C446 7193 D4B8 1E35 8984 7731 C661 64A5 0CF1 526D
diff -ur gal.old/ChangeLog gal/ChangeLog --- gal.old/ChangeLog 2004-06-10 18:31:46.099163384 -0500 +++ gal/ChangeLog 2004-06-10 18:29:53.040350936 -0500 @@ -1,3 +1,8 @@ +2004-06-10 Jon Oberheide <jon focalhost com> + + * gal/a11y/e-table/gal-a11y-e-table-item.c: fix a compilation error + exposed by gcc 3.4.0 with a forward declaration of eti_reinit_data + 2004-06-09 Radek Doulik <rodo ximian com> * gal/e-text/e-text.c (capitalize): process only if len > 0 diff -ur gal.old/gal/a11y/e-table/gal-a11y-e-table-item.c gal/gal/a11y/e-table/gal-a11y-e-table-item.c --- gal.old/gal/a11y/e-table/gal-a11y-e-table-item.c 2004-06-10 18:32:05.592199992 -0500 +++ gal/gal/a11y/e-table/gal-a11y-e-table-item.c 2004-06-10 18:08:17.684274992 -0500 @@ -45,6 +45,8 @@ GtkWidget *widget; }; +static gpointer* eti_reinit_data (AtkTable *table, + ETableItem *item); static gboolean gal_a11y_e_table_item_ref_selection (GalA11yETableItem *a11y, ESelectionModel *selection); static gboolean gal_a11y_e_table_item_unref_selection (GalA11yETableItem *a11y);
Attachment:
signature.asc
Description: This is a digitally signed message part