Re: [evolution-patches] Patch for adding support to Recurrences in GW events

[Harish Krishnaswamy <kharish novell com>]

hi,

 thanks for the review. i will switch to /* */ and add the memory frees.
Conversion from EGwItem to ECalcomponents has been omitted because of a
scope limitation with the GW SOAP interface.. We support the recurrences
created in Evolution to be expanded into individual items in the server
but can retrieve them only as individual calendar items. We would be
tidying this up once the server interface is finalized and the
implementation is made available.

thanks,
harish

On Fri, 2004-06-11 at 03:36, Rodrigo Moya wrote:
> On Fri, 2004-06-11 at 00:04 +0530, Harish Krishnaswamy wrote:
> > hi,
> > 
> > the following patch contains the code for supporting recurrences in GW
> > events plus minor code changes to support assignment of tasks to
> > multiple users.
> > 
> 
> > +static gboolean 
> > +get_recur_instance (ECalComponent *comp, time_t instance_start, time_t
> > instance_end, gpointer data)
> > +{
> > +	GSList **recur_dates = (GSList **) data;
> > +	char *rdate;
> > +
> > +	rdate = isodate_from_time_t (instance_start);
> > +	// convert this into a date
> >
> use /* .. */ for comments
> 
> > @@ -259,6 +304,7 @@ e_gw_item_to_cal_component (EGwItem *ite
> >
> isn't in this function missing the conversion of the EGwItem's recur
> dates to ECalComponent's?
> 
> > +               e_cal_component_set_attendee_list (comp,
> > attendee_list);
> > +       }
> > +
> I think you are missing a call to e_cal_component_free_attendee_list.
> 
> > +               // FIXME  is it safe to assume 'from; is the
> > organizer.
> > +               
> > +               // update Recipient Status
> > +               // look for accepted/declined and update the item else
> > set it
> > +               // to none.
> >
> again, use /* ... */ for comments.
> 
> > +void
> > +e_gw_item_set_recurrence_dates (EGwItem  *item, GSList
> > *new_recurrence_dates)
> > +{
> > +       /* free old list and set a new one*/
> > +       g_slist_foreach (item->priv->recurrence_dates, free_string,
> > NULL);
> > +       item->priv->recurrence_dates = new_recurrence_dates;
> > +}
> > +
> you are missing a call to g_slist_free (item->priv->recurrence_dates);
> 
> cheers
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches