Re: [Fwd: Re: [evolution-patches] Patch for #ifdef'ed GtkFileChooser support]

[JP Rosevear <jpr novell com>]

On Wed, 2004-07-28 at 12:48 -0700, Chris Toshok wrote:
> doh, mailed this just to Carlos.
> Email message/mailbox attachment, "Forwarded message - Re: [evolution-
> patches] Patch for #ifdef'ed GtkFileChooser support"
> On Wed, 2004-07-28 at 12:48 -0700, Chris Toshok wrote:
> > I'd rather see this patch use a feature check instead of a version
> > check...
> > 
> > ala:
> > 
> > 	#if USE_GTKFILECHOOSER
> > 
> > instead of
> > 
> > 	#if GTK_CHECK_VERSION(2,4,0)
> > 
> > since there's no single header included by every .c in evo (except
> > config.h), the check for gtk version would probably have to go in
> > configure.in.
> > 
> > The code in the addressbook section looks good.  What do others think
> > about the #if check?

I'm ok with it, on the *general* principle (I know zucchi in particular
thinks this particular widgets is a regression) that we should strive to
use newer gnome/gtk stuff when possible as part of being a good GNOME
citizen.  

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.