[Fwd: Re: [evolution-patches] Patch for #ifdef'ed GtkFileChooser support]

[Chris Toshok <toshok ximian com>]

doh, mailed this just to Carlos.

--- Begin Message ---

• From: Chris Toshok <toshok ximian com>
• To: Carlos Garnacho <garnacho tuxerver net>
• Subject: Re: [evolution-patches] Patch for #ifdef'ed GtkFileChooser support
• Date: Wed, 28 Jul 2004 11:08:43 -0700

I'd rather see this patch use a feature check instead of a version
check...

ala:

	#if USE_GTKFILECHOOSER

instead of

	#if GTK_CHECK_VERSION(2,4,0)

since there's no single header included by every .c in evo (except
config.h), the check for gtk version would probably have to go in
configure.in.

The code in the addressbook section looks good.  What do others think
about the #if check?

Chris

On Wed, 2004-07-21 at 11:19 +0200, Carlos Garnacho wrote:
> Hi,
> 
> I've attached a patch for using GtkFileChooser if the Gtk+ version that
> evo has been compiled against is >= 2.4.0, if not, it will use
> GtkFileSelection. Seems OK to you?
> 
>         Carlos
> 
> 
> 
> !DSPAM:40fe8dd0994461615120944!

--- End Message ---