yea, I think I'd prefer it be done this way too. Jeff On Wed, 2004-07-28 at 12:48 -0700, Chris Toshok wrote: > doh, mailed this just to Carlos. > Email message/mailbox attachment, "Forwarded message - Re: [evolution- > patches] Patch for #ifdef'ed GtkFileChooser support" > On Wed, 2004-07-28 at 12:48 -0700, Chris Toshok wrote: > > I'd rather see this patch use a feature check instead of a version > > check... > > > > ala: > > > > #if USE_GTKFILECHOOSER > > > > instead of > > > > #if GTK_CHECK_VERSION(2,4,0) > > > > since there's no single header included by every .c in evo (except > > config.h), the check for gtk version would probably have to go in > > configure.in. > > > > The code in the addressbook section looks good. What do others think > > about the #if check? > > > > Chris > > > > On Wed, 2004-07-21 at 11:19 +0200, Carlos Garnacho wrote: > > > Hi, > > > > > > I've attached a patch for using GtkFileChooser if the Gtk+ version that > > > evo has been compiled against is >= 2.4.0, if not, it will use > > > GtkFileSelection. Seems OK to you? > > > > > > Carlos > > > > > > > > > > > > !DSPAM:40fe8dd0994461615120944! -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. fejj ximian com - www.novell.com
Attachment:
smime.p7s
Description: S/MIME cryptographic signature