Re: [evolution-patches] [Fwd: [composer, mailer] #59490 Signature is prefixed with '> " in replies]

[Not Zed <notzed ximian com>]

A couple of minor things.

If you're going to compare a size_t against -1 you should use ~0, or alternatively make it a ssize_t as size_t isn't signed.

And this bit looks abiguous, since arguments are normally pushed onto the stack right to left, and ',' expressions are evaluated right to left.

+               e_msg_composer_set_pending_body (composer, em_utils_part_to_html (mime_part, &len), len);

e.g. put len (undefined) on the stack, then evaluate something that calculates it.

At least thats the way i remember the language working.  But to make it clearly unambiguous i'd suggest separating out the statements, even if it actually works.

Otherwise looks good.

On Fri, 2004-07-23 at 18:34 +0200, Radek Doulík wrote:
>     On Tue, 2004-07-20 at 20:40 +0800, Not Zed wrote:
> >         
> >         umm, that email contains an embedded 0, it should be put into the body therefore.
> >         
> >         gtkhtml handles binary doesn't it?  its probably a bug that any of the code is using strlen at all.
> >     
>     I cooked second patch to avoid using strlen there as well. OK to commit?
>     
>     R.

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer