Re: [evolution-patches] [Fwd: [composer, mailer] #59490 Signature is prefixed with '> " in replies]

[Radek Doulík <rodo novell com>]

On Tue, 2004-07-20 at 18:37 +0800, Not Zed wrote:
>     On Tue, 2004-07-20 at 12:15 +0200, Radek Doulík wrote:
> >         On Tue, 2004-07-20 at 18:02 +0800, Not Zed wrote:
> > >             
> > >             I dont think you want to do this, this will stuff up the 'is the message changed' state.
> > >         
> >         it doesn't leave the changed flag up (it's cleared later). it also speeds up the composer start as you don't have to dup whole message content. so I think it's better to do it that way.
> >     
>     
>     That really wont make it any slower.
>     
>     But sure if it doesn't mess up undo, sure.  e.g. if you reply/hit new and hit close and it closes with no question.
yup, tested it and it works OK.

> > >             The embedded NUL character issue should be trivial to fix.
> > >         
> >         well, I tried to find the place, but I was soon lost in the all the formatting stuff.
> >     
>     
>     So how exactly does this code make any difference?
>     
>     The old code does strlen() on the content, the same as the new code.  It thus can't possibly include any embedded NUL, should one even exist in the string passed in.  Unless its that code being removed which added the NUL.
the difference is that it 1st sets the body text (before it set body text concatenated with signature text) and then it calls e_msg_composer_show_sig_file which sets the signature independently.

before it set the concatenated content which looked like this:

<blockquote type="cite">body text la la la end of text<br>signature

note the missing </blockquote> there. it's lost in the process of formatting. it's because the text variable passed to set_editor_text is sometime string looking like this:

<blockquote type="cite">body text la la la end of text\0</blockquote>

the middle \0 comes from that:
>     The problem is that when mailer formats the text/html part, it adds \0 at the end of stream. em-format-quote.c:emqf_format_message then adds </blocquote>...., but it's placed after the \0 from formatter. It doesn't bite us there anymore, but might be good idea to fix it anyway.
I wasn't able to find where is that \0 added. I hope you might be able to spot it easier and fix that part as well.

I am attaching the test case mail, which demonstrates this. If I created new HTML mail in evo and replied to it, it didn't reproduce the bug.

R.


>From Regina Glaser fab at Tue Jun  1 12:18:43 2004
Return-Path: <bounce=Regina Glaser#afab at=97=3edb=johann glaser gmx at>
Delivered-To: hansi donbosco sth ac at
Received: (qmail 30026 invoked from network); 1 Jun 2004 12:18:43 -0000
Received: from unknown (HELO mx0.gmx.net) (213.165.64.100) by
	jupiter.donbosco.sth.ac.at with SMTP; 1 Jun 2004 12:18:43 -0000
Received: (qmail 14292 invoked by alias); 1 Jun 2004 12:18:47 -0000
Delivered-To: GMX delivery to johann glaser gmx at
Received: (qmail 14112 invoked by uid 65534); 1 Jun 2004 12:18:46 -0000
Received: from webmail.bfi-bbrz.at (EHLO sv084.office.root.local)
	(62.218.36.4) by mx0.gmx.net (mx010) with SMTP; 01 Jun 2004 14:18:46 +0200
Received: from SV110.office.root.local ([172.17.33.186]) by
	sv084.office.root.local with Microsoft SMTPSVC(6.0.3790.0); Tue, 1 Jun 2004
	14:18:43 +0200
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01C447D2.8C66F7F5"
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Subject: Geburtstag
Date: Tue, 1 Jun 2004 14:18:29 +0200
Message-ID: <8BDA593CB900584D9C394A0A85CD8470047F5C SV110 office root local>
Thread-Topic: Geburtstag
Thread-Index: AcRH0pQwEC8j8BjSRkGyemIXEQpxGA==
From: "Glaser Regina" <Regina Glaser fab at>
To: <johann glaser gmx at>
X-OriginalArrivalTime: 01 Jun 2004 12:18:43.0022 (UTC)
	FILETIME=[94506EE0:01C447D2]
X-GMX-Antispam: 0 (Mail was not recognized as spam)
X-Resent-By: Forwarder <forwarder gmx at>
X-Resent-For: johann glaser gmx at
X-Resent-To: hansi donbosco sth ac at
X-UIDL: bid!!NR4!!+EW!!Pm\"!
Status: U
X-Evolution-Source: pop://hansi pop
X-Evolution: 00000336-0010

This is a multi-part message in MIME format.

------_=_NextPart_001_01C447D2.8C66F7F5
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hallo Hansi,
ich w=FCnsche dir alles Gute zum Geburtstag und dass es vor allem =
beruflich ein besonders erfolgreiches Jahr wird.
Bis sp=E4ter
Mama

------_=_NextPart_001_01C447D2.8C66F7F5
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE>Nachricht</TITLE>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Diso-8859-1">
<META content=3D"MSHTML 6.00.2800.1264" name=3DGENERATOR></HEAD>
<BODY>
<DIV><SPAN class=3D336041512-01062004><FONT face=3DArial size=3D2>Hallo=20
Hansi,</FONT></SPAN></DIV>
<DIV><SPAN class=3D336041512-01062004><FONT face=3DArial size=3D2>ich =
w=FCnsche dir=20
alles Gute zum Geburtstag und dass es vor allem beruflich ein besonders=20
erfolgreiches Jahr wird.</FONT></SPAN></DIV>
<DIV><SPAN class=3D336041512-01062004><FONT face=3DArial size=3D2>Bis=20
sp=E4ter</FONT></SPAN></DIV>
<DIV><SPAN class=3D336041512-01062004><FONT face=3DArial=20
size=3D2>Mama</FONT></SPAN></DIV></BODY></HTML>
=00
------_=_NextPart_001_01C447D2.8C66F7F5--