Re: [evolution-patches] Resent in text format - gw connector update for the GW server fixes in recurrence, group events.

[Rodrigo Moya <rodrigo novell com>]

On Fri, 2004-07-23 at 21:36 +0530, Harish Krishnaswamy wrote:
> hi,
>  resending this in txt format... 
>  The patch is an update following the server fixes for recurrence
> creation and group events. 
> Bugs 57651, 58643 and 58637 that were blocked by the server defects are
> resolved by this patch.
> The interface changes are in conformance to the schema available in the
> cvs.
> 
> 			server_uid = (char *) l->data;
> -				e_cal_comp = e_cal_component_clone (comp);
> -				/* set a new uid*/
> -				e_cal_component_get_uid (comp, (const char **) &uid);
> -				new_uid = g_strdup_printf ("%s%d", uid, i);
> -				e_cal_component_set_uid (comp, new_uid); 
> -				g_free (new_uid);
> -				set_container_id (backend, e_cal_comp, server_uid);
> -				g_free (server_uid);
> +				item = (EGwItem *) tmp->data;
> +				e_cal_comp = e_gw_item_to_cal_component (item, priv->default_zone); 
> +				e_cal_component_commit_sequence (e_cal_comp);
> +				sanitize_component (backend, e_cal_comp, g_ptr_array_index (uid_array, i));
>
probably would be better to call commit_sequence after
sanitize_component, right?


> -	case ICAL_METHOD_REPLY:
> +	case ICAL_METHOD_REQUEST:
>  		/* get attendee here and add the list along. */
>  		if (e_cal_component_has_attendees (comp))
>  		{
>
this should be in the same line as the if statement.


> Index: calendar/backends/groupwise/e-cal-backend-groupwise-utils.h
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-server/calendar/backends/groupwise/e-cal-backend-groupwise-utils.h,v
> retrieving revision 1.8
> diff -u -p -r1.8 e-cal-backend-groupwise-utils.h
> --- calendar/backends/groupwise/e-cal-backend-groupwise-utils.h	23 Jul 2004 07:01:32 -0000	1.8
> +++ calendar/backends/groupwise/e-cal-backend-groupwise-utils.h	23 Jul 2004 10:14:42 -0000
> @@ -40,8 +40,8 @@ void          e_gw_item_set_changes (EGw
>   * Connection-related utility functions
>   */
>  EGwConnectionStatus e_gw_connection_create_appointment (EGwConnection *cnc, const char *container, icaltimezone *default_zone, ECalComponent *comp, GSList **id_list);
> -EGwConnectionStatus e_gw_connection_send_appointment (EGwConnection *cnc, const char *container, icaltimezone *default_zone, ECalComponent *comp, icalproperty_method method);
> -EGwConnectionStatus e_gw_connection_get_freebusy_info (EGwConnection *cnc, GList *users,						       time_t start, time_t end, GList **freebusy, icaltimezone *default_zone);
> +EGwConnectionStatus e_gw_connection_send_appointment (EGwConnection *cnc, const char *container, ECalComponent *comp, icalproperty_method method);
> +EGwConnectionStatus e_gw_connection_get_freebusy_info (EGwConnection *cnc, GList *users, time_t start, time_t end, GList **freebusy, icaltimezone *default_zone);
>  
this code (having the default_zone argument) was added by Chen twice, so
not sure if you should be removing it. Chen?

cheers