Re: [evolution-patches] patch for #58701 (addressbook)

[Sivaiah N <snallagatla novell com>]

On Sun, 2004-07-18 at 05:58, Chris Toshok wrote:
> On Sat, 2004-07-17 at 11:14 +0530, Sivaiah N wrote:
> > Ok, So in case of *_start_book_view call i don't think it matters
> > whether backends use e_book_backend_sexp or not as anyway
> > e_data_book_view_notify_update  does the matching by calling
> > e_book_backend_sexp_match_contact before updating the view
> 
> Hmm, actually it seems silly to use e_data_book_view_notify_update, as
> the only thing that can ever happen is an _add from start_book_view, but
> that's beside the point I suppose.
> 
> > Groupwise backend  does the  things similar to  file backend  both in
> > start_book_view  and get_contact_list methods.

> How does it work?  iterate over all contacts on the server?  or does it
> generate a query?
Actually it maintains summary, so first we see whether it is summary
query or not. If it is , we search over  summary to get ids of the
matching contacts and get only those contacts from server. Otherwise we
get all contacts present in the book and 
iterate over them and match against query.

> > Exchange and Ldap backends seems not calling
> > e_book_backend_sexp_match_contact in get_contact_list method
> 
> Yeah, the sexp stuff in the backends that require it (to translate an
> evolution sexp into something the server can handle) should really be
> rich enough to represent queries over any fields, unless the server
> doesn't support such queries.  In those cases it makes sense to use a
> more general query and call e_book_backend_sexp_match_contact.
> 
> > And now that i see i should move e_contact_address_free inside if to
> > make sure that i don't leak address in any case.
> 
> Yeah, just before the "if (rv)" check.
> 
> > Ok to commit this ?
> 
> Yeah, we can always go back later and fix the uses of
> e_data_book_view_notify_update.
> 
committed
Thanks,
Siva
> Chris
> 
> > Thanks,
> > Siva
> > 
> > 
> > 
> > On Fri, 2004-07-16 at 22:55, Chris Toshok wrote:
> > > looks good here, although this only works for the backends that actually
> > > use e-book-backend-sexp.c (file/vcf).  I can't remember if the
> > > exchange/ldap/gw backends do things properly.
> > > 
> > > Chris
> > > 
> > > On Fri, 2004-07-16 at 19:53 +0530, Sivaiah N wrote:
> > > > Hi,
> > > > The attached patch implements compare_address function in
> > > > e-book-backend-sexp.c so that search can happen overs values present in
> > > > address files in contact
> > > > Thanks,
> > > > Siva
> > > > 
> > > > 
> > > > 
> > > _______________________________________________
> > > evolution-patches mailing list
> > > evolution-patches lists ximian com
> > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > 
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > 
> > 
> > !DSPAM:40f8becb326352066743408!
> > 
> > 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches