Re: [evolution-patches] patch for #58701 (addressbook)



Ok, So in case of *_start_book_view call i don't think it matters
whether backends use e_book_backend_sexp or not as anyway
e_data_book_view_notify_update  does the matching by calling
e_book_backend_sexp_match_contact before updating the view

Groupwise backend  does the  things similar to  file backend  both in
start_book_view  and get_contact_list methods.

Exchange and Ldap backends seems not calling
e_book_backend_sexp_match_contact in get_contact_list method

And now that i see i should move e_contact_address_free inside if to
make sure that i don't leak address in any case.

Ok to commit this ?

Thanks,
Siva



On Fri, 2004-07-16 at 22:55, Chris Toshok wrote:
> looks good here, although this only works for the backends that actually
> use e-book-backend-sexp.c (file/vcf).  I can't remember if the
> exchange/ldap/gw backends do things properly.
> 
> Chris
> 
> On Fri, 2004-07-16 at 19:53 +0530, Sivaiah N wrote:
> > Hi,
> > The attached patch implements compare_address function in
> > e-book-backend-sexp.c so that search can happen overs values present in
> > address files in contact
> > Thanks,
> > Siva
> > 
> > 
> > !DSPAM:40f7e651681301238656870!
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]