Re: [evolution-patches] 2 mailer leak fixes

[Not Zed <notzed ximian com>]

looks good, please commit.

On Mon, 2004-07-19 at 16:07 -0400, Jeffrey Stedfast wrote:

2 memory leak fixes

Plain text document attachment (camel-leak.patch)

? 55280.patch
? 61551.patch
? ChangeLog.nonximian
? body
? body.c
? body.txt
? body2.txt
? braindamaged.patch
? camel-gpg.0.verify.data
? camel-gpg.0.verify.signature
? camel-gpg.1.verify.data
? camel-gpg.1.verify.signature
? camel-gpg.2.verify.data
? camel-gpg.2.verify.signature
? camel-gpg.3.verify.data
? camel-gpg.3.verify.signature
? camel-leak.patch
? camel-namespace.patch
? cf.c
? charset-map.c
? charset-map.diff
? class.sh
? cmsutil.c
? date.patch
? flags
? foo
? foo.txt
? foo2.txt
? gw-body.txt
? imap
? invalid-content-id.patch
? iso
? iso.c
? namespace.sh
? patch
? pop3-uidl.patch
? smime
? uid-cache.patch
? providers/tmp
? providers/local/camel-mozilla-folder.c
? providers/local/camel-mozilla-folder.h
? providers/local/camel-mozilla-store.c
? providers/local/camel-mozilla-store.h
? tests/data/camel-mime-tests.tar.gz
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
retrieving revision 1.2221
diff -u -r1.2221 ChangeLog
--- ChangeLog	19 Jul 2004 02:11:31 -0000	1.2221
+++ ChangeLog	19 Jul 2004 20:09:30 -0000
@@ -1,3 +1,8 @@
+2004-07-19  Jeffrey Stedfast  <fejj novell com>
+
+	* providers/imap/camel-imap-store.c (get_subscribed_folders): Free
+	result after parsing it. Fixes a leak.
+
 2004-07-16  Not Zed  <NotZed Ximian com>
 
 	* camel-gpg-context.c: Added some debug stuff.
Index: providers/imap/camel-imap-store.c
===================================================================
RCS file: /cvs/gnome/evolution/camel/providers/imap/camel-imap-store.c,v
retrieving revision 1.297
diff -u -r1.297 camel-imap-store.c
--- providers/imap/camel-imap-store.c	17 Jun 2004 14:25:14 -0000	1.297
+++ providers/imap/camel-imap-store.c	19 Jul 2004 20:09:30 -0000
@@ -2479,6 +2479,7 @@
 		}
 		
 		fi = parse_list_response_as_folder_info (imap_store, result);
+		g_free (result);
 		if (!fi)
 			continue;
 		

Plain text document attachment (mailer-leak.patch)

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3416
diff -u -r1.3416 ChangeLog
--- ChangeLog	16 Jul 2004 16:03:44 -0000	1.3416
+++ ChangeLog	19 Jul 2004 20:12:43 -0000
@@ -1,3 +1,13 @@
+2004-07-19  Jeffrey Stedfast  <fejj novell com>
+
+	* em-migrate.c (em_migrate_folder): Free uri and name
+	strings. Fixes a leak.
+
+2004-07-15  Jeffrey Stedfast  <fejj novell com>
+
+	* em-format-html-display.c (efhd_bonobo_object): If the part is a
+	text part, do charset conversion.
+
 2004-07-13  Jeffrey Stedfast  <fejj novell com>
 
 	* em-folder-view.c (emfv_message_reply): Chck that the selection
Index: em-migrate.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-migrate.c,v
retrieving revision 1.44
diff -u -r1.44 em-migrate.c
--- em-migrate.c	21 May 2004 03:14:16 -0000	1.44
+++ em-migrate.c	19 Jul 2004 20:12:43 -0000
@@ -1736,6 +1736,8 @@
 	}
 	res = 0;
 fatal:
+	g_free (uri);
+	g_free (name);
 	g_string_free(src, TRUE);
 	g_string_free(dest, TRUE);
 	if (local_store)

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer