Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)
- From: JP Rosevear <jpr ximian com>
- To: Michael Terry <mterry fastmail fm>
- Cc: evolution-patches ximian com, jimmac ximian com
- Subject: Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)
- Date: Sat, 10 Jan 2004 11:02:45 -0500
On Wed, 2004-01-07 at 18:04, JP Rosevear wrote:
> On Wed, 2003-12-24 at 19:59, Michael Terry wrote:
> > This patch is a proposed fix for bug 127812. It expands the role of
> > e-icon-factory from being a helper class in shell to being the
> > authoritative source for all icons inside Evolution.
>
> What is the reasoning behind you moving it? Also it would probably be
> better to include <e-util/e-icon-factory.h> instead of fiddling with the
> includes so e-util is directly in the include path.
>
> > It uses GnomeIconTheme to pull requested icons. It affects all modules
> > that use icons (most of them). This patch might change some of the
> > icons visibly -- in particular with the Tools->Settings... dialog. If
> > an icon cannot be found, a blank placeholder icon is used instead, so
> > even though several of the icons are not present in gnome-icon-theme
> > (see bug 129294), Evolution is still usable.
>
> Maybe Jakub can comment on availability. Basically we can't ship with
> out all the icons in place (although as many as possible should be
> used).
Jakub said he should be done with the icon theme in a week or two. I
think what we might do is hold on to this patch until then.
-JP
--
JP Rosevear <jpr ximian com>
Ximian, Inc.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]