Doh. Sorry. Tuomas asked for screenshots to help speed things along. http://primates.ximian.com/~dobey/evolution-1-5-select-names-hig.png is approximately what the patch changes the dialog to look like, with the exception that the outward border spacing is correct. :) -- dobey On Mër , 2004-01-07 at 13:54, Rodney Dawes wrote: > On Mar , 2004-01-06 at 14:40, William Jon McCann wrote: > > Rodney Dawes wrote: > > > Have no fear. It does indeed conflict with your patch. :-/ It also takes > > > about 5 seconds for evolution to open the mail. And, it's getting to the > > > point where it's going to conflict with a lot more patches. I wish it > > > would have been submitted in much smaller chunks. I split out the > > > select-names.glade part into another file to patch my build with, so I > > > could see how much it affected the work I am about to do to fix another > > > buglet/request in that dialog, and the dialog is still not totally > > > HIG-compliant. Hrmm... > > > > Sorry about the size. It took more than 5 seconds to write though ;) > > > > I am sure you will find that it does not make evolution 100% HIG > > compliant. It should go quite a way though. Situations where the > > change needs some design discussion where skipped entirely for this > > iteration. > > Sure. I would expect the dialogs that it does touch, though, to be > close to, if not, 100% HIG-compliant. The ESelectNames dialog changes > in the patch did not do that though. > > I'm attaching a new patch to addressbook/gui/component/select-names/ > which does make the dialog HIG compliant for things other than the > GtkFrame. The patch also fixes bug 51966 (the reason I fixed the patch, > since it conflicts with the changes I needed to make for the bug), and > also resolves a mnemonic conflict. _C for "Category:" and "Cancel". > > With Tuomas's approval, I will commit these changes. I would like to see > the dialog re-designed, but I don't think we have time for that right > now. This at least solves immediate issues. > > -- dobey >
Attachment:
signature.asc
Description: This is a digitally signed message part
