On Sht , 2004-01-03 at 04:53, Martyn Russell wrote: > On Sat, 2004-01-03 at 00:47, Jeffrey Stedfast wrote: > > could you split this into 1 patch for each toplevel directory? > > > > ie, one for mail/, one for addresbsook/, one for shell/, etc > > > > this will make it easier for us to review (since I can only OK the mail > > changes, I don't wan tto have to read thru pages and pages of other > > changes) > > The mail config glade file and a few other source changes have been higified in a patch i submitted about 3 months ago. See here: > http://lists.ximian.com/archives/public/evolution-patches/2003-October/003291.html > > I fear this patch will conflict with my patch. I have been waiting some time for my patch to be checked in, and have already had to re-do it because of conflicts. I would like to avoid this happening again. :) Have no fear. It does indeed conflict with your patch. :-/ It also takes about 5 seconds for evolution to open the mail. And, it's getting to the point where it's going to conflict with a lot more patches. I wish it would have been submitted in much smaller chunks. I split out the select-names.glade part into another file to patch my build with, so I could see how much it affected the work I am about to do to fix another buglet/request in that dialog, and the dialog is still not totally HIG-compliant. Hrmm... Tuomas? Can we plow through this patch soon? -- dobey
Attachment:
signature.asc
Description: This is a digitally signed message part