Re: [evolution-patches] Mailer bug #127521: Inline PGP support for evolution (part A: only sending)

[Jeffrey Stedfast <fejj ximian com>]

No, what NotZed means is that when you clearsign, you should call a
function:

camel_gpg_context_clearsign()

Don't add any flags to camel_cipher_context_sign() and don't add a
camel_cipher_contxt_clearsign() either.

so basically, just make your gpg_clearsign() private function into a
public function called camel_gpg_context_clearsign() and call it
directly.

Jeff

On Tue, 2004-01-06 at 21:24, Bohumir Jelinek wrote:
> > 
> > I have anohter comment on the patch, I think you should not add a
> > clearsign method to the camel_cipher_context, but only to the
> > camel_gpg_context, as only pgp can clearsign stuff.
> > 
> 
> Since
> 
>    "mime sign" called   "sign"    from camel_cipher_context
> 
> therefore
> 
>   "clear sign" called "clearsign" from camel_cipher_context
> 
> I will add boolean parameter (inline/mime) to "sign" function in
> camel_cipher_context, is it all right?
> 
> -Bohumir
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com