[evolution-patches] Re: Various libebook patches

[Chris Toshok <toshok ximian com>]

On Wed, 2004-01-07 at 00:13, Ross Burton wrote:
> On Wed, 2004-01-07 at 01:42, Chris Toshok wrote:
> > On Thu, 2004-01-01 at 08:03, Ross Burton wrote: 
> > > 2) Removal of old-style addressbook opening functions
> > > 
> > > e_book_load_local_addressbook and e_book_get_default_addressbook have
> > > hard-coded paths to the local address books.  At the moment,
> > > get_default_addressbook() even loads the Evo1.4 book.
> 
> > I agree that the default_addressbook call should be removed, but I
> > think the local addressbook call should stay.  It should always load
> > the addressbook that corresponds to On This Computer/Personal.  People
> > shouldn't have to deal with ESource's when all they want is a tool
> > that modifies their personal addressbook.
> 
> What if the user deletes/renames On This Computer/Personal?  Just return
> NULL? Or the first addressbook in On This Computer?

We can just always use FALSE for @only_if_exists in the
local_addressbook case so it'll create it if it's not present.  IMO it
shouldn't be something the user can delete/rename anyway, but that's a
separate (UI) issue.

> > otherwise things look ok.
> 
> Fab.  OK to commit the patches?

yup.  Make sure to commit a ChangeLog entry too :)

Chris