Re: [evolution-patches] patch for addres book-config.c

[Sivaiah N <snallagatla novell com>]

commited after making base_uri type as const char *

Thanks,
Siva
On Wed, 2004-08-25 at 10:13 -0500, Hans Petter Jansson wrote:
> On Wed, 2004-08-25 at 12:28 +0530, Sivaiah N wrote:
> > updated patch attached. For some reason mime type of attachements is
> > being detect as application/octetstream in my machine. 
> 
> This looks good to commit, with one minor change: You should declare
> base_uri as 'const char *', since that's what's returned by
> e_source_group_peek_base_uri ().
> 
> Using const where appropriate also makes source easier to read, since
> it's an indicator of which strings belong to you (e.g. if they need to
> be freed later) and which ones don't.
>