Re: [evolution-patches] patch for addres book-config.c
- From: Hans Petter Jansson <hpj ximian com>
- To: Sivaiah N <snallagatla novell com>
- Cc: evolution-patches ximian com
- Subject: Re: [evolution-patches] patch for addres book-config.c
- Date: Wed, 25 Aug 2004 10:13:16 -0500
On Wed, 2004-08-25 at 12:28 +0530, Sivaiah N wrote:
> updated patch attached. For some reason mime type of attachements is
> being detect as application/octetstream in my machine.
This looks good to commit, with one minor change: You should declare
base_uri as 'const char *', since that's what's returned by
e_source_group_peek_base_uri ().
Using const where appropriate also makes source easier to read, since
it's an indicator of which strings belong to you (e.g. if they need to
be freed later) and which ones don't.
--
Hans Petter
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]