Re: [evolution-patches] patch for addres book-config.c

[Hans Petter Jansson <hpj ximian com>]

On Sat, 2004-08-14 at 13:21 +0530, Sivaiah wrote:

> Currently groupwise part can not handle address book folder renaming ,
> so we need to disable the ui to stop rename operation.This parch does
> that. This patch also also sets sets the "use_ssl" property on the new
> boos created which  is missed earlier.

For some reason, I have to save your patches to disk and view them with
Emacs, since Evolution won't show them inline. Anyhow, here goes:


> +	if (source && g_str_has_prefix  ( e_source_group_peek_base_uri (dialog->source_group), "groupwise://"))
> +		gtk_widget_set_sensitive (GTK_WIDGET(dialog->display_name), FALSE);

Since apparently e_source_group_peek_base_uri () returns NULL on some
occasions, you should get it to a temp variable and do

if (source && base_uri && g_str_has_prefix (...))

Also, there are some spurious spaces on that line - after
g_str_has_prefix and then again after the opening parenthesis. There
should be exactly one space before the parenthesis and none after.

-- 
Hans Petter