Re: [evolution-patches] [Contacts] Patch for 62142

[Chris Toshok <toshok ximian com>]

On Wed, 2004-08-11 at 13:13 -0500, Hans Petter Jansson wrote:
> On Wed, 2004-08-11 at 10:15 -0700, Chris Toshok wrote:
> > On Wed, 2004-08-11 at 00:26 -0500, Hans Petter Jansson wrote:
> 
> > > The EABEditor/EContactEditor save/close logic isn't all that hot on the
> > > whole, but for now I'm keeping the changes minimal to reduce the risk of
> > > new bugs.
> > > 
> > > I was unable to test moving between a mix of read-only and writable
> > > books, since apparently the file backend thinks everything is writable
> > > regardless of file system permissions (it didn't use to be like that),
> > > and I had to hardwire read-onlyness into the code to test.
> 
> > Yeah, that's definitely a bug.  A one-liner by the looks of it in e-
> > book-backend-file.
> 
> Can you post a patch for it?

well, my one-liner broke something else :)  going to spend a little time
on it now though.

> > > Anyway, this fixes bug 62142 in a narrow sense, meaning it will no
> > > longer prompt to save if no changes were made. I replaced the old dialog
> > > code used in delete_event_cb() with a shorter bit using existing utility
> > > functions.
> 
> > why not replace this entire function with a call to
> > eab_editor_prompt_to_save_changes (along with one line to close the
> > dialog if that function returns TRUE)?
> 
> > Seems you're ending up with a function that does basically what
> > eab_editor_prompt_to_save_changes does..
> 
> I wanted to do that, but the editor would be closed prematurely then -
> the UI will be destroyed, and the save function needs it in case
> something goes wrong. So I need to leave it open and pass TRUE for
> should_close.

_prompt_to_save_changes doesn't destroy the dialog, though - it leaves
that up to the caller.

> As I mentioned, the existing save/close logic ain't all that hot...

What specifically is wrong with it?

Chris