Re: [evolution-patches] [Contacts] Patch for 62142

[Chris Toshok <toshok ximian com>]

On Wed, 2004-08-11 at 00:26 -0500, Hans Petter Jansson wrote:
> The EABEditor/EContactEditor save/close logic isn't all that hot on the
> whole, but for now I'm keeping the changes minimal to reduce the risk of
> new bugs.
> 
> I was unable to test moving between a mix of read-only and writable
> books, since apparently the file backend thinks everything is writable
> regardless of file system permissions (it didn't use to be like that),
> and I had to hardwire read-onlyness into the code to test.

Yeah, that's definitely a bug.  A one-liner by the looks of it in e-
book-backend-file.

> Anyway, this fixes bug 62142 in a narrow sense, meaning it will no
> longer prompt to save if no changes were made. I replaced the old dialog
> code used in delete_event_cb() with a shorter bit using existing utility
> functions.

why not replace this entire function with a call to
eab_editor_prompt_to_save_changes (along with one line to close the
dialog if that function returns TRUE)?

Seems you're ending up with a function that does basically what
eab_editor_prompt_to_save_changes does..


i.e.:

--

if (eab_editor_prompt_to_save_changes (EAB_EDITOR (ce)))
	eab_editor_close (EAB_EDITOR (ce));

return TRUE;

--

Chris