Re: [evolution-patches] patch for adresbook.c

[Chris Toshok <toshok ximian com>]

On Wed, 2004-08-11 at 23:04 +0530, Sivaiah N wrote:
> attached the newer version of pathc which uses "anon-access" capability
> 
> Thanks,
> Siva
> On Wed, 2004-08-11 at 17:01 +0530, Sivaiah N wrote:
> > Hi,
> > Currently in address book component When user cancels the auth dialog
> > evolution always display a dialog with "Accessing LDAP Server
> > anonymously" and sens a start_book_view request to e-d-s. The attached
> > patch makes it to happen only in ldap case as anonymous access is not
> > possible inother cases like groupwise.
> > 
> > Thanks,
> > Siva

looks good except for the following very minor thing:


> ===================================================================
> RCS
> file: /cvs/gnome/evolution/addressbook/gui/component/addressbook.c,v
> retrieving revision 1.238
> diff -u -r1.238 addressbook.c
> --- gui/component/addressbook.c 12 Jul 2004 18:28:08 -0000      1.238
> +++ gui/component/addressbook.c 11 Aug 2004 17:37:00 -0000
> @@ -80,8 +80,15 @@
>  
>         if (status != E_BOOK_ERROR_OK) {
>                 if (status == E_BOOK_ERROR_CANCELLED) {
> +                               
> +                       if (e_book_check_static_capability (book,
> "anon-access")) {
>                         /* the user clicked cancel in the password
> dialog */

That comment should go between the two if's, not inside the inner if.

Chris