Re: [evolution-patches] [Fwd: eds/calendar, crash import fix]

[JP Rosevear <jpr novell com>]

On Thu, 2004-08-05 at 15:58 +0200, Rodrigo Moya wrote:
> On Thu, 2004-08-05 at 15:49 +0800, Not Zed wrote:
> > 
> > > > ok i'll leave it in your hands then.
> > > > 
> > > > imo the code shouldn't crash because of any data missing or corrupt
> > > > though as it does now.
> > > > 
> > > yes, right, it shouldn't crash. I was just saying to make it refuse an
> > > icalcomponent without an UID, but JP is right that we already do
> > > duplicate UID checking and change it, so I guess it's ok then.
> > So shall I just commit as is then? :)
> >
> there is a comment from JP that still apply:
> 
> > If comp_uid is NULL after trying to generate it, we should still bail
> > out with an error, invalid object or something.  We need the uid (and
> > the spec demands it).
> > 
> so, you should just check the return value from e_cal_component_gen_uid and return
> GNOME_Evolution_Calendar_InvalidObject if it's NULL.

Its only technical though, gen_uid should only return NULL of out of
memory afaict.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.