Re: [evolution-patches] [Fwd: eds/calendar, crash import fix]

[Not Zed <notzed ximian com>]

> > > If comp_uid is NULL after trying to generate it, we should still bail
> > > out with an error, invalid object or something.  We need the uid (and
> > > the spec demands it).
> > Ok, I wasn't sure on that.
> > 
> > But these external calendars seem to have this quite often, i just
> > wonder if it will be needed for interoperability.  It seems odd to me
> > that the importer isn't doing some pre-processing to cope with this
> > though, rather than opening the data directly in the backend code. 
> >
> yes, the importer code could deal with this, but the **importer code**,
> not the backend. So I would add that code to the importers code rather
> than to the backend.

ok i'll leave it in your hands then.

imo the code shouldn't crash because of any data missing or corrupt though as it does now.

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer