Re: [evolution-patches] [Fwd: eds/calendar, crash import fix]

[Rodrigo Moya <rodrigo novell com>]

On Wed, 2004-08-04 at 11:51 +0800, Not Zed wrote:
> > > > If comp_uid is NULL after trying to generate it, we should still bail
> > > > out with an error, invalid object or something.  We need the uid (and
> > > > the spec demands it).
> > > Ok, I wasn't sure on that.
> > > 
> > > But these external calendars seem to have this quite often, i just
> > > wonder if it will be needed for interoperability.  It seems odd to me
> > > that the importer isn't doing some pre-processing to cope with this
> > > though, rather than opening the data directly in the backend code. 
> > >
> > yes, the importer code could deal with this, but the **importer code**,
> > not the backend. So I would add that code to the importers code rather
> > than to the backend.
> 
> ok i'll leave it in your hands then.
> 
> imo the code shouldn't crash because of any data missing or corrupt
> though as it does now.
> 
yes, right, it shouldn't crash. I was just saying to make it refuse an
icalcomponent without an UID, but JP is right that we already do
duplicate UID checking and change it, so I guess it's ok then.

-- 
Rodrigo Moya <rodrigo novell com>